Augur/8 Knot WG Meeting, Jan 20, 2026 ![rw-book-cover](https://img.youtube.com/vi/X_p_v8HahQk/maxresdefault.jpg) ๐Ÿ”— **Source:** [Augur/8 Knot WG Meeting, Jan 20, 2026](https://www.youtube.com/watch?v=X_p_v8HahQk&pp=0gcJCdMKAYcqIYzv) > [!note]+ Document Notes > tags: #augur #chaos-engineering #celery #data-collection #debugging > author: Augur/8 Knot WG > source: YouTube > reference: https://www.youtube.com/watch?v=X_p_v8HahQk > date created: 2026-01-20 16:45 > > # ๐Ÿท๏ธ Title: Augur/8 Knot WG Meeting - Debugging Secondary Collection Issues Before Chaos Con > <!-- deep-read:sections start --> ## ๐Ÿงฐ Action Inbox - [H1] Deploy Andrew's workaround for celery chaining bug โ€” test before maintainers call #celery #debugging - [H2] Document release process for redundancy โ€” create issue after Chaos Con #documentation #process - [H3] Query other instances to check secondary collection status โ€” community validation #data-collection ## ๐Ÿงญ Table of Contents - [[#๐Ÿ“ Summary]] - [[#๐Ÿ“– Main Content]] - [[#๐Ÿ—’๏ธ Notes]] - [[#๐Ÿ“š References]] - [[#๐Ÿ—ฃ๏ธ Paraphrase]] - [[#๐Ÿ“ฐ Newsletter]] - [[#โœ… Action Items]] - [[#๐Ÿงช Hypotheses]] - [[#๐Ÿ“Š Methodology]] - [[#โ“ Questions]] - [[#๐Ÿ”ฎ Future Research]] - [[#๐Ÿ’ก Implications]] - [[#๐Ÿง  Learning Styles Assessment]] - [[#๐Ÿ“Š Accessibility Assessment]] - [[#๐ŸŒ DEIB Assessment]] - [[#โœ… Logical Validity]] - [[#๐Ÿ›ก๏ธ DARVO Analysis]] - [[#๐ŸŽฏ Conclusion]] ### ๐Ÿ”— References - [Augur Repository](https://github.com/chaoss/augur) - [Celery Documentation](https://docs.celeryproject.org/) ## ๐Ÿ“ Summary - **What happened**: Augur team debugging critical secondary collection failure where pull request review comments task never schedules - **Why it matters**: Blocking all secondary data collection since December, threatening release readiness for Chaos Con - **Key stakeholders**: Augur maintainers (Adrian, Callie, Sean), community instances - **Risks and tradeoffs**: Workaround maintains data integrity but doesn't fix root celery chaining bug - **Bottom line**: Team identified celery bug in nested chains within groups, testing Andrew's workaround before maintainers call ## ๐Ÿ“– Main Content The Augur team is experiencing a critical bug where secondary data collection has been failing since December 2026. The issue stems from a celery chaining problem where the "collect pull request review comments" task never gets scheduled, even though all other secondary collection tasks complete successfully. This appears to be related to known celery bugs when nesting chains within groups of tasks. The team has identified that their Red Hat instance is the only one reporting this issue, making debugging more complex. Adrian tested an initial workaround that didn't maintain proper task ordering, prompting Andrew to suggest embedding the comments function call directly within the pull request reviews task to ensure proper sequencing. The urgency is heightened by the approaching Chaos Con deadline, where the team needs a stable release. Core and facade collection are working well, but secondary collection is completely blocked by this scheduling issue. ## ๐Ÿ—’๏ธ Notes #### โฑ๏ธ [00:00](https://youtu.be/X_p_v8HahQk?t=0) โ€” [H1] Meeting opening and high velocity release prep - Key idea: Light agenda due to Chaos Con preparation timeline - Evidence: "We're kind of like in a high velocity release process right now in preparation for Chaos Con" #### โฑ๏ธ [02:30](https://youtu.be/X_p_v8HahQk?t=150) โ€” [H1] Secondary collection blocking issue identified - Key idea: Celery chaining bug preventing pull request review comments from scheduling - Evidence: "This is pretty tendering pretty much all progress on secondary collection" #### โฑ๏ธ [04:15](https://youtu.be/X_p_v8HahQk?t=255) โ€” [H2] First attempted fix failed due to ordering - Key idea: Initial workaround broke task completion ordering requirements - Evidence: "It means that the scheduling is ordered not the completion is ordered" #### โฑ๏ธ [06:45](https://youtu.be/X_p_v8HahQk?t=405) โ€” [H1] Andrew's suggested workaround approach - Key idea: Embed comments function inside reviews task to maintain ordering - Evidence: "Putting that inside of pull request review to make it to where it has to be in order" #### โฑ๏ธ [08:20](https://youtu.be/X_p_v8HahQk?t=500) โ€” [H2] Core and facade collection working well - Key idea: Issue is isolated to secondary collection workflows - Evidence: "Facade and core are kind of well-oiled machines at this point" #### โฑ๏ธ [10:30](https://youtu.be/X_p_v8HahQk?t=630) โ€” [H2] Celery chaining efficiency rationale - Key idea: Task dependencies prevent expensive database operations - Evidence: "It's really inefficient if the app starts to insert data into the database that doesn't have parent records" #### โฑ๏ธ [14:00](https://youtu.be/X_p_v8HahQk?t=840) โ€” [H1] Task never scheduling vs getting stuck - Key idea: Problem is scheduling failure, not execution failure - Evidence: "They're never get like that task is never getting scheduled. It's not that they're getting stuck" #### โฑ๏ธ [18:15](https://youtu.be/X_p_v8HahQk?t=1095) โ€” [H2] Red Hat instance isolation puzzling - Key idea: Only Red Hat instance experiencing this issue - Evidence: "The fact that it's only us is really strange, too" #### โฑ๏ธ [25:40](https://youtu.be/X_p_v8HahQk?t=1540) โ€” [H2] Testing query for other instances - Key idea: Need to verify if other instances have same problem - Evidence: "I can give you a good query or know if good is the right an easy query to figure that out" #### โฑ๏ธ [30:20](https://youtu.be/X_p_v8HahQk?t=1820) โ€” [H3] Sean's instance showing successful collection - Key idea: Sean's instance has functioning secondary collection with proper ordering - Evidence: "I've got a bunch of them... both are going" #### โฑ๏ธ [35:45](https://youtu.be/X_p_v8HahQk?t=2145) โ€” [H1] Screenshot evidence of scheduling failure - Key idea: Comments task shows "received" but never "started" - Evidence: "Pull request reviews comments succeed. And this isn't even started yet. It's only received" #### โฑ๏ธ [42:30](https://youtu.be/X_p_v8HahQk?t=2550) โ€” [H2] Data integrity maintained in workaround - Key idea: Andrew's solution preserves ordering and data consistency - Evidence: "I think it does hold our data the data integrity is intact" #### โฑ๏ธ [47:10](https://youtu.be/X_p_v8HahQk?t=2830) โ€” [H3] Release process documentation needed - Key idea: Adrian requesting documented release procedures for redundancy - Evidence: "Having documentation for like what what are the steps that a maintainer should go through to do a release" #### โฑ๏ธ [49:00](https://youtu.be/X_p_v8HahQk?t=2940) โ€” [H3] Current release process is artisan - Key idea: Release process currently exists only in Sean's knowledge - Evidence: "It's an artisan bespoke process right now very popular in Portland but not necessarily something you should do for open source software" ## ๐Ÿ“š References - [Celery Chain Documentation](https://docs.celeryproject.org/en/stable/userguide/canvas.html#chains) - [Augur Secondary Collection](https://github.com/chaoss/augur) - [Flower Monitoring Tool](https://flower.readthedocs.io/) ## ๐Ÿ—ฃ๏ธ Paraphrase - The Augur team is rushing to fix a critical bug where secondary data collection has been broken since December due to a celery task scheduling issue - Their Red Hat instance is the only one experiencing this problem where pull request review comments tasks never get scheduled despite other tasks succeeding - They're testing a workaround that embeds the comments collection directly into the reviews task to maintain proper ordering while preserving data integrity ## ๐Ÿ“ฐ Newsletter **Augur Tackles Critical Collection Bug Before Chaos Con** The Augur team is working through a complex debugging session as they prepare for their Chaos Con release. They've identified a celery chaining bug that's been blocking secondary data collection since December, specifically preventing pull request review comments from being scheduled. What makes this particularly challenging is that only their Red Hat instance is experiencing this issue, while other community instances continue working normally. The team is testing a pragmatic workaround suggested by Andrew that maintains data integrity while they investigate the root cause. This highlights the importance of having multiple test instances and community feedback in identifying edge cases that might not surface in smaller deployments. Resources: [Augur Repository](https://github.com/chaoss/augur), [Celery Documentation](https://docs.celeryproject.org/), [CHAOSS Community](https://chaoss.community/) ## โœ… Action Items #### DevRel - Community management: Create query for other instances to check secondary collection status - Education: Document troubleshooting steps for celery chaining issues #### OSPO - Software Inventory: Track celery version dependencies across instances - Developer Support: Create debugging runbooks for collection failures #### Community - Contributors: Engage community to validate collection status across instances - Maintainers: Document release process for better redundancy ## ๐Ÿงช Hypotheses - The celery chaining bug is specific to certain repository sizes or complexity patterns - Different celery versions across instances may explain the isolation to Red Hat's deployment - The issue emerged from a dependency upgrade that occurred around December 2026 - Nested celery chains within groups have known stability issues in production environments ### ๐Ÿ“Š Methodology - Query multiple community instances using the secondary collection status query - Compare celery versions and configuration across working vs failing instances - Test Andrew's workaround on isolated repositories before full deployment - Monitor flower dashboard for scheduling patterns after implementing fix ### โ“ Questions - Why is only the Red Hat instance experiencing this celery chaining issue? - What changed in December that could have triggered this scheduling failure? - Should the embedded function approach become the permanent solution or just a temporary workaround? ### ๐Ÿ”ฎ Future Research - Investigate celery version compatibility with nested chain patterns - Develop automated testing for task scheduling dependencies - Create monitoring alerts for collection pipeline failures ### ๐Ÿ’ก Implications - Practice: Need better monitoring and alerting for collection pipeline health - Policy: Require documentation of release processes for all critical projects - Security: Collection failures could create blind spots in repository analysis - Education: Teams need training on celery debugging and task dependency patterns ### ๐Ÿง  Learning Styles Assessment Reading level estimate: 12th grade #### ๐Ÿ‘€ Visual learners - Present: Flower dashboard screenshots, task flow diagrams - Improve: Celery chain architecture diagrams, task dependency visualizations #### ๐Ÿ”Š Aural learners - Present: Meeting recording with detailed discussion - Improve: Audio walkthrough of debugging process #### ๐Ÿ—ฃ๏ธ Verbal learners - Present: Technical terminology explained in context - Improve: Glossary of celery and augur-specific terms #### ๐Ÿงฉ Kinesthetic learners - Present: Hands-on debugging session, query testing - Improve: Step-by-step troubleshooting checklist #### ๐Ÿง  Logical learners - Present: Clear cause-and-effect analysis of scheduling failure - Improve: Decision tree for debugging collection issues #### ๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘ Social learners - Present: Collaborative problem-solving session - Improve: Community validation process for fixes #### ๐Ÿง˜โ€โ™€๏ธ Solitary learners - Present: Individual analysis of logs and monitoring data - Improve: Self-guided debugging documentation #### ๐ŸŒฟ Naturalistic learners - Present: Pattern recognition across different instances - Improve: Ecosystem thinking about dependency relationships ### ๐Ÿ“Š Accessibility Assessment #### Screen reader semantics - Present: Well-structured meeting with clear speaker identification - Improve: Transcript formatting with semantic markup #### Keyboard navigation - Present: Standard video controls accessible - Improve: Timestamped navigation for key topics #### Contrast and readability - Present: Clear audio quality for speech recognition - Improve: High-contrast transcript formatting #### Text resizing and reflow - Present: Transcript scales appropriately - Improve: Mobile-friendly timestamp navigation #### Media and captions - Present: Full transcript available - Improve: Time-synced captions, speaker identification #### Forms and interactions - Present: Standard video interface - Improve: Accessible bookmark and note-taking tools ### ๐ŸŒ DEIB Assessment #### Cultural breadth - Present: Global open source community considerations - Improve: Multiple timezone accommodation for debugging sessions #### Inclusive language - Present: Technical terms explained clearly - Improve: Avoid insider jargon, provide context for newcomers #### Neurodiversity support - Present: Clear structure with defined agenda items - Improve: Written summary of action items, visual progress tracking #### Representation - Present: Collaborative decision-making across team members - Improve: Ensure diverse perspectives in technical discussions #### Psychological safety - Present: Open discussion of uncertainties and knowledge gaps - Improve: Explicit encouragement for questions from community members ### โœ… Logical Validity #### Strong reasoning - Deductive strength: Clear logic from celery chaining principles to scheduling behavior - Inductive strength: Pattern recognition from similar celery issues in community - Causal reasoning: Systematic elimination of potential causes for scheduling failure - Analogical strength: Comparison with working instances to isolate variables #### Fallacies - False cause: Assuming timing correlation equals causation without deeper investigation - Hasty generalization: Concluding Red Hat instance is unique without broader community survey #### Tone of voice - Overall tone: Collaborative problem-solving with technical precision and appropriate urgency ### ๐Ÿ›ก๏ธ DARVO Analysis - Deny: No defensive patterns observed - Attack: No attacks on reporting or investigation - Reverse victim/offender: No victim-blaming present - Emotional cues: Professional frustration with technical challenges, appropriate for debugging context ## ๐ŸŽฏ Conclusion The Augur team is methodically addressing a critical celery chaining bug that threatens their Chaos Con release timeline. While they've identified a viable workaround that preserves data integrity, the isolation of this issue to a single instance suggests deeper investigation is needed. The collaborative debugging approach and community validation strategy demonstrate good open source practices for handling complex technical issues under time pressure. ## ๐Ÿงฑ Refactor Appendix ### ๐Ÿ“š Literature Split Pad Purpose: Stage CEE units that become Literature notes. Split level: H3 ### [H1] Celery chaining creates task execution dependencies > [!quote] [Augur/8 Knot WG Meeting](https://youtu.be/X_p_v8HahQk) by Augur Team via YouTube. Published 2026-01-20. Accessed 2026-01-20. > "The chaining exists because it's really inefficient if the app starts to insert data into the database that doesn't have parent records." Technical rationale for why task ordering matters in data collection pipelines. [view highlight](https://youtu.be/X_p_v8HahQk?t=630#H1) #xref #articleseed ID:rw_augur_chaining ### [H2] Nested celery structures cause known scheduling bugs > [!quote] [Augur/8 Knot WG Meeting](https://youtu.be/X_p_v8HahQk) > "There's some known celery bugs where those kinds of structures don't work like those nested chains within groups." Evidence of celery limitations with complex task dependency structures. [view highlight](https://youtu.be/X_p_v8HahQk?t=840#H2) #xref ID:rw_celery_bugs --- ### ๐Ÿ”– Atomic Split Pad (Zettel Candidates) Purpose: Promote reusable claims into Atomic notes. Split level: H4 #### [Z1] Task scheduling order differs from completion order - Scope: Celery chains ensure receive order but not completion sequencing - Pointer --- ## Full Transcript [00:01] Hello, welcome to the Auger 8 not auger<br>[00:04] meeting for January 20th, 2026<br>[00:08] and um we have a very light agenda today<br>[00:11] but open to other things. Welcome to<br>[00:14] Johnson who's joined us and um Cali<br>[00:18] Adrian um the one thing that Adrian had<br>[00:22] thought of before Chaos Con and that's<br>[00:24] we're kind of like in a high velocity<br>[00:27] release process right now in preparation<br>[00:30] for Chaos Con.<br>[00:34] Um,<br>[00:36] so that's what we're kind of we've got<br>[00:39] kind of a light agenda, which is pretty<br>[00:41] typical, and we're trying to get a<br>[00:42] release out, which is also pretty<br>[00:44] typical. Um, so Johnson, before we kind<br>[00:48] of go on with our agenda and the poll<br>[00:50] request reviews that we were pl we were<br>[00:53] going to do here, do you have anything<br>[00:55] that that you want to bring up?<br>[01:06] Not really. Not really. All right. No,<br>[01:12] >> maybe I'll have some questions at the<br>[01:13] end, but um not for now.<br>[01:15] >> All right, that sounds good.<br>[01:26] So, right now I am staring at<br>[01:31] the startup screen to see if Adrian's<br>[01:34] branch works.<br>[01:37] >> Yeah. Adrian, have you What's the state<br>[01:39] of our like because we Yeah, I think<br>[01:40] there's a lot of We're all like testing<br>[01:42] different things actively right now.<br>[01:46] Yeah, I I have yet to<br>[01:48] um undo the state of that one repo. Um<br>[01:53] >> Okay.<br>[01:54] >> But I think the the I have an image that<br>[01:56] should be built for the new the second<br>[01:58] test. So I'll do that after this call.<br>[02:00] Um I've been getting a little distracted<br>[02:03] because I think um our department's<br>[02:05] trying to put together a promo video and<br>[02:06] I've been asked to record some people in<br>[02:07] the Boston office. So I'm like<br>[02:10] >> Slack messages and telling people to<br>[02:12] throw it on my calendar and I'll deal<br>[02:13] with it later. Yeah, that makes sense.<br>[02:16] Um,<br>[02:18] for some context, um, I it's probably<br>[02:21] worth like more of a conversation in<br>[02:23] like the maintainers call of like how do<br>[02:25] we want to handle this long term with<br>[02:28] the issue that comes from chaining. It<br>[02:31] doesn't seem like there was that the bug<br>[02:33] was from the augur side, but more of a<br>[02:37] celery issue. Um, either way, need to<br>[02:41] find a way around it. Um the first<br>[02:44] attempt that Adrian tried out yesterday<br>[02:48] um once I saw it this morning I was like<br>[02:50] oh I get why this doesn't work. Um and<br>[02:53] so by taking it out of the chain even<br>[02:55] though it was ordered um it means that<br>[02:57] the scheduling is ordered not the<br>[03:00] completion is ordered. Um so wasn't a<br>[03:04] good solution for the problem at hand.<br>[03:07] Um, but Andrew had suggested just<br>[03:10] putting the pull request comments<br>[03:12] function inside of the pull or it's pull<br>[03:16] request review comments and putting that<br>[03:18] inside of pull request review um to make<br>[03:23] it to where it has to be in order, but<br>[03:24] it's in the same um seems like a pretty<br>[03:28] good workaround, but probably is worth a<br>[03:30] discussion of how to actually fix the<br>[03:32] issue instead of patching the issue. Um,<br>[03:35] but we're looking for a patch for right<br>[03:37] now for the very least that we can keep<br>[03:39] collection moving. Um, because this is<br>[03:41] pretty<br>[03:43] tendering pretty much all progress on<br>[03:46] secondary collection. So, that's kind of<br>[03:50] what we're working on on the Red Hat<br>[03:54] side of house. Um, because for us, um,<br>[03:58] facade and core are kind of welloiled<br>[04:01] machines at this point. I mean, we still<br>[04:03] have there's some smaller errors that we<br>[04:06] want to work on, but um nothing like a<br>[04:10] major hindrance like we are with<br>[04:12] secondary right now. Um<br>[04:17] yeah.<br>[04:21] Do we want to look at that issue,<br>[04:22] Adrian? like um I don't have a I haven't<br>[04:26] up you know since we talked yesterday<br>[04:27] afternoon I haven't gotten myself up to<br>[04:29] speed with it entirely but is there<br>[04:31] something that um you think we can look<br>[04:33] at<br>[04:34] >> uh with our secondary things?<br>[04:36] >> Yeah. Um, I think it's mostly I'm I'm<br>[04:39] mostly I think it's mostly dependent on<br>[04:41] what our results of our second. So, the<br>[04:43] first test was just me tinkering around<br>[04:45] with sort of the ordering of the celery<br>[04:48] sort of workflow um to try and see if<br>[04:52] that worked and I don't it didn't seem<br>[04:53] like that worked. Um, so I I tried<br>[04:57] there's a suggestion from Andrew that he<br>[04:59] made on Discord yesterday that I was<br>[05:01] like, "Hey, that that's actually a that<br>[05:03] that it helps increase our road map<br>[05:05] because I didn't I didn't have any other<br>[05:06] ideas after that first one." So, we're<br>[05:08] trying that one now. I'll probably be<br>[05:10] deploying that after this call and we'll<br>[05:11] we'll probably know before the<br>[05:12] maintainers call whether or not that<br>[05:14] worked. Um, that might be a better<br>[05:16] conversation like if we want to deep<br>[05:18] dive into that, that might be better for<br>[05:19] the maintainers call cuz we we'll<br>[05:20] probably have like Andrew and some other<br>[05:22] people who pretty much wrote the<br>[05:24] collection process like there to help.<br>[05:27] Yeah, I mean I c I certainly know that<br>[05:28] the chaining is one of the strategies<br>[05:30] that we used to insert to make the<br>[05:33] dependencies between the tasks be<br>[05:36] handled by the app cuz it's really<br>[05:38] inefficient if the app starts to insert<br>[05:42] data into the database that doesn't have<br>[05:45] parent records because that basically<br>[05:47] just offloads the sequence of collection<br>[05:50] to um<br>[05:53] it offloads the sequence of collection<br>[05:54] to the database which gets extremely<br>[05:56] expensive on a server. So that's why the<br>[05:59] chaining exists. I don't doubt there is<br>[06:01] some kind of celery chaining issue. Um<br>[06:05] >> yeah, I'm not I'm not questioning why<br>[06:06] they have to be run in a particular or<br>[06:08] like I was I I was just asking because I<br>[06:09] I didn't 100% know, but I I I understand<br>[06:12] that they have to be in this done in the<br>[06:13] right order. Um it's just I think the<br>[06:16] fact that we had that chain nested<br>[06:18] within a group of other tasks in Celery,<br>[06:20] I think there's some known celery bugs<br>[06:22] at least for based on a quick search. um<br>[06:25] where like th those kinds of structures<br>[06:28] don't s like I guess there's some salary<br>[06:30] bugs with that and we were seeing that<br>[06:32] the the pull request reviews like the<br>[06:35] first part of that chain was running and<br>[06:37] getting scheduled and completing but we<br>[06:39] were not seeing anything even scheduled<br>[06:40] for the second one. Um and so it's like<br>[06:44] what what's going on here? Why is this<br>[06:46] not scheduling? Because if the second<br>[06:48] piece of that change is not scheduling,<br>[06:49] that whole group is probably not<br>[06:51] completing or that whole that whole line<br>[06:53] is probably not completing and then the<br>[06:54] whole group is not going and then it's<br>[06:56] not going to get marked as success. So,<br>[06:58] it's just kind of like I I do need I do<br>[07:01] probably need a lot more context on like<br>[07:02] how how scheduling works and how how all<br>[07:05] that's kind of supposed to work in terms<br>[07:07] of because I I know I think Callie's<br>[07:10] been trying to look at Flower and see<br>[07:12] like whether tasks are scheduled and<br>[07:14] whether they're completing and I I think<br>[07:16] I remember some conversations a while<br>[07:17] ago about how we may be only scheduling<br>[07:22] the number of tasks that like can be<br>[07:23] processed right like by the number of<br>[07:25] workers we have or something. So, we're<br>[07:26] maybe not Those maybe aren't being<br>[07:29] scheduled, but then maybe I I don't<br>[07:31] there might be some kind of weird stuff<br>[07:33] going on there that we could we could<br>[07:34] look into, but that might be better for<br>[07:36] the maintainers call.<br>[07:38] >> Okay, that sounds good.<br>[07:43] I don't have anything.<br>[07:46] >> Um I did see your message on Slack. Do<br>[07:48] you want to quickly jump back to your So<br>[07:50] that that issue you were testing. So it<br>[07:52] it seems like you said it worked, but<br>[07:53] you ran into a different error. Um<br>[07:55] you're<br>[07:56] >> Yeah, but I don't think the error I<br>[07:57] think the error is just like um<br>[08:00] unrelated to anything.<br>[08:02] >> Yeah. So that particular error when one<br>[08:05] of the routes is crashing because the<br>[08:07] like request reports isn't um like a<br>[08:11] function doesn't exist. Um one of the<br>[08:13] one of the commits or one of the PRs<br>[08:14] we've gotten recently resolves that. Um<br>[08:16] I think I I preemptively just sort of<br>[08:18] added that to the current milestone so<br>[08:20] you can find it easily if you want to<br>[08:22] test that and review that. But<br>[08:26] yeah.<br>[08:26] >> All right, that sounds it's added to the<br>[08:28] milestone now.<br>[08:32] >> Um,<br>[08:34] >> all right. So, this worked. I'm going to<br>[08:55] Sorry. Something stupid that I was<br>[08:57] doing.<br>[09:02] Okay, now I have to fix that.<br>[09:08] Sorry.<br>[09:40] What was that? PR name.<br>[09:42] >> Uh, the one with your issue 3516 I think<br>[09:46] is the number.<br>[10:00] They screwed up the drainage.<br>[10:03] >> I can I can pull it low. I can pull it<br>[10:05] on mine. And<br>[10:06] >> yeah, pull it on yours. And<br>[10:08] >> you're just trying to remove the commits<br>[10:09] for that one extra file.<br>[10:10] >> I'm trying to remove the commits for the<br>[10:11] extra file, which was basically me just<br>[10:13] making sure I had my GitHub configured,<br>[10:15] which was stupid, but<br>[10:18] that's where we are.<br>[10:23] Okay, I'll just force push that branch<br>[10:24] with the<br>[10:26] previous version.<br>[10:29] >> Meanwhile, it does look like things are<br>[10:31] running<br>[10:32] and I didn't get any errors. So, you<br>[10:35] might think it's definitely<br>[10:38] definitely fixes the bare metal issue.<br>[10:42] Sweet.<br>[10:45] I guess feel free to merge it. I don't I<br>[10:48] don't think this<br>[10:50] should affect I mean it it's yeah this<br>[10:52] should this should be fine um if it I<br>[10:55] mean it was passing all the tests I<br>[10:56] think before so<br>[10:58] >> hey I I it says I was requested for<br>[11:01] review but I did the review I thought<br>[11:05] >> it might have it might have um not<br>[11:08] submitting it would help but um<br>[11:10] >> I think also sometimes if if you force<br>[11:12] push it will dismiss all the approving<br>[11:15] reviews or thing. Uh, do you want me to<br>[11:18] rebase it as well or<br>[11:23] I guess it doesn't?<br>[11:24] >> No, it should it should be fine. This<br>[11:35] What do I want to do here? I haven't<br>[11:36] seen this before, but it's probably a by<br>[11:38] >> I think GitHub's been starting to like<br>[11:39] kind of like force that. I don't You<br>[11:41] don't super have to. I tend to prefer<br>[11:43] rebase. Um,<br>[11:45] >> all right. But<br>[11:48] >> yeah,<br>[11:51] >> but also if you click rebase, it's going<br>[11:53] to have to rerun all the tests. So if<br>[11:55] you're waiting for the tests to pass,<br>[11:57] then<br>[11:58] >> I think we're good.<br>[12:01] They passed already.<br>[12:09] >> Wait.<br>[12:13] Um, and then what what was I I wasn't<br>[12:16] sure how much I picked up of this from<br>[12:17] from the various maintainers calls, but<br>[12:18] like what are your kind of criteria for<br>[12:20] when to release? Like it sounds like<br>[12:22] you're kind of wanting the obviously to<br>[12:23] be able to<br>[12:24] >> bring up the main have it not have any<br>[12:26] major issues.<br>[12:29] >> Not issues is important.<br>[12:35] Stability is important. So like all the<br>[12:38] all the CR passes<br>[12:41] uh CI passes<br>[12:44] there are there's nothing on our road<br>[12:46] map for that release that's missing that<br>[12:49] we think we need and I think it sounds<br>[12:52] like right now we do want to possibly<br>[12:55] try to solve this issue with secondary<br>[12:57] collection before we release. like it<br>[13:00] seems like that falls under the category<br>[13:02] of something that's really important to<br>[13:04] fix that that we should also release<br>[13:08] that happening on other people's<br>[13:09] instances.<br>[13:11] >> Um I I don't see how it wouldn't, but we<br>[13:14] are the only instance that's reporting<br>[13:16] this problem.<br>[13:24] Yeah, because I also noticed I think<br>[13:25] when I was trying the initial version,<br>[13:27] >> what would you evaluate if I was<br>[13:29] experiencing the problem?<br>[13:31] >> Um, I can give you a good query or know<br>[13:35] if good is the right an easy query to<br>[13:38] figure that out. I'll put this<br>[13:40] >> huge fan huge fan of easy.<br>[13:43] >> Um because if you look at I'm gonna put<br>[13:46] this in the thread that's about this<br>[13:48] issue. Where is it? Um give me just a<br>[13:54] second.<br>[14:04] Um, I just send it the channel because<br>[14:06] then you can see how long it's been<br>[14:08] since you've had a You have to go to the<br>[14:11] bottom of all your NLES, but the first<br>[14:13] it orders your um like collection by the<br>[14:18] um last collected on date for secondary.<br>[14:21] And so you can kind of see if how long<br>[14:25] has it been since you've had successful<br>[14:29] secondary collection. Somewhere in<br>[14:32] December we stopped having successful<br>[14:36] secondary collection and I don't know<br>[14:39] why.<br>[14:41] That's also a big portion of it is like<br>[14:42] why did this like happen? Was it a<br>[14:46] upgrade? Did we upgrade some packages<br>[14:49] that ended up like<br>[14:51] unknowingly impacting this?<br>[14:54] Um maybe were the ones that were<br>[14:57] passmber.<br>[14:58] >> What<br>[14:59] >> did you say? September.<br>[15:00] >> December.<br>[15:01] >> You said December.<br>[15:02] >> December. Okay.<br>[15:05] Um yeah because the last time that we<br>[15:07] have seen<br>[15:10] any successful collection<br>[15:14] um for secondary has been in December<br>[15:17] but mostly<br>[15:19] my theory is that it might be<br>[15:20] repositories that don't have any PRs and<br>[15:23] so it never even gets and so there might<br>[15:26] be something that's like oh no PR<br>[15:28] reviews and so you don't need to go to<br>[15:31] PR commits. I'm not that's a that is a<br>[15:35] completely uninvestigated theory.<br>[15:38] >> So yeah, let me show you what I'm<br>[15:41] seeing. So I've got nulls first. That's<br>[15:44] the default behavior.<br>[15:46] >> So um pardon me. This is kind of a a<br>[15:49] wide query result, but the secondary<br>[15:53] data last collected in this column.<br>[15:56] Obviously, I'm getting secondary data.<br>[16:02] That fact makes me ask the question<br>[16:05] about whether or not the things that<br>[16:08] your instance may be stuck on are in<br>[16:10] fact very large repos<br>[16:12] if<br>[16:12] >> but they're not getting scheduled. Like<br>[16:14] it's like they're never get like that<br>[16:16] task is never getting scheduled. It's<br>[16:18] not that they're getting stuck. All of<br>[16:20] the other four tasks that are related to<br>[16:22] secondary are completing are getting<br>[16:25] scheduled and succeeding<br>[16:28] and the like pull request review comment<br>[16:33] is never being seen by our instance. And<br>[16:37] so it'd be interesting to see if your<br>[16:39] instance is scheduling if you can go to<br>[16:42] flower. Um I was curious to see if you<br>[16:48] control F<br>[16:50] >> on um<br>[16:55] I'll put this just in.<br>[17:01] >> All right. I'm in I'm in flower now.<br>[17:04] >> Just a collect. I just put it in persist<br>[17:06] like I'm I'm just putting these in<br>[17:07] Slack. So then you can see like they're<br>[17:09] there. um<br>[17:16] just to see if that task is ever<br>[17:18] scheduling. It's the very last thing. I<br>[17:20] already put it down there.<br>[17:21] >> Collect pull request review comments.<br>[17:23] >> Okay, hold on. Sorry.<br>[17:25] >> Yeah, if you just search for that in the<br>[17:26] tasks tab of<br>[17:28] >> copy and paste.<br>[17:29] >> Uh okay.<br>[17:33] >> Oops.<br>[17:35] >> Select. Yeah,<br>[17:36] >> if I typo it, it's really nasty.<br>[17:39] review<br>[17:41] >> comments. Yeah,<br>[17:43] >> I've got a bunch of them.<br>[17:44] >> There's a lot that looks like there. Um<br>[17:48] do like um do like secondary task. I'm<br>[17:51] curious if you're seeing secondary<br>[17:53] success. Um<br>[17:55] >> I would assume he is.<br>[17:57] >> Yeah.<br>[17:57] >> Yeah.<br>[18:01] >> So, I mean that I haven't looked into<br>[18:02] this. Obviously the smell is that<br>[18:05] there's some kind of scheduling issue on<br>[18:07] secondary but so is any nothing is<br>[18:10] collecting at all though.<br>[18:11] >> No everything but that everything but<br>[18:15] >> the comment task that you searched for<br>[18:17] is the thing that as far as I can tell<br>[18:19] seems to be blocking the success task<br>[18:21] from running<br>[18:22] >> because it seems like in your case both<br>[18:23] are going.<br>[18:24] >> Yeah. So ours are never even scheduling.<br>[18:27] So it doesn't even give our instances<br>[18:29] shot to have a sex a successful<br>[18:34] um secondary collection because if it<br>[18:35] never gets scheduled it can never<br>[18:37] succeed.<br>[18:37] >> Yeah. Yeah. So you're just you're saying<br>[18:40] if I'm hearing correctly pull request<br>[18:41] review comments never I don't if I made<br>[18:44] the same query on your flower dashboard<br>[18:46] I would see no successful completed pull<br>[18:48] request review comment tasks in my<br>[18:49] >> see nothing. It would just have a blank<br>[18:51] response.<br>[18:52] >> Nothing.<br>[18:53] >> None would be none would be pending.<br>[18:55] None would be like about to run just<br>[18:58] nothing at all.<br>[18:59] >> Yeah.<br>[19:00] >> But other secondary tasks are running.<br>[19:02] >> All of them. All the rest of them are<br>[19:04] running<br>[19:06] and succeeding.<br>[19:09] >> How big are so<br>[19:12] how big are the repos? So pull request<br>[19:14] review comments is never even starting<br>[19:16] or never succeeding.<br>[19:17] >> It is or oh comments is never being<br>[19:19] started. It is never being scheduled. So<br>[19:21] it doesn't have anything to do with<br>[19:23] size. the size this the size does not<br>[19:25] matter if it never even gets it doesn't<br>[19:28] get scheduled.<br>[19:30] >> What's the task before what what's the<br>[19:32] last task that you can see in the chain<br>[19:34] that's scheduled Adrian?<br>[19:36] >> I mean so all of the<br>[19:38] >> right before the pull requests like the<br>[19:39] pull requ the one that goes right before<br>[19:41] the comments one is we're seeing that<br>[19:43] succeeding we're just not seeing<br>[19:45] >> so pull request reviews is succeeding.<br>[19:48] >> Yes.<br>[19:48] >> Yes. But then for some reason the the<br>[19:50] task that's changed immediately after it<br>[19:52] is somehow not running. That's sort of<br>[19:54] what leads me to think that this is pro<br>[19:56] I feel like from my just super quick<br>[19:59] cursory search of open celery issues<br>[20:01] because my various AI assistants were<br>[20:04] saying like this is a common issue in<br>[20:05] celery and I I went and looked at their<br>[20:06] issues and and checked and it looks like<br>[20:08] there are quite a few issues in celery<br>[20:11] related to just various flavors of like<br>[20:14] nesting things in other nesting like<br>[20:17] chains inside groups or something like<br>[20:19] that. Um, so I suspect that that could<br>[20:23] be a very plausible cause.<br>[20:26] >> Um, yeah,<br>[20:28] >> the fact that it's only us is really<br>[20:30] strange, too. I'm not sure what the heck<br>[20:31] is happening there.<br>[20:32] >> The fact that it's quote unquote really<br>[20:33] you also is is a factor that just has me<br>[20:39] has me<br>[20:39] >> also you've got a bigger instance than<br>[20:41] us. So like it's not even like this was<br>[20:44] like some of my some of the tests like<br>[20:45] the test cases we were running yesterday<br>[20:47] were running f like I was seeing these<br>[20:49] successes on my local my tiny local dev<br>[20:53] instance<br>[20:55] our prod is not happy it's not working a<br>[20:59] like what you ran locally though yet I<br>[21:04] yes it showed successes but that's like<br>[21:07] that that was not a correct solution<br>[21:11] Um because the way that you implemented<br>[21:15] it yesterday did not require<br>[21:18] um pull request reviews to finish before<br>[21:20] pull request review comments.<br>[21:23] >> It should have that that's<br>[21:25] >> No, it didn't like because you you don't<br>[21:27] have any training just it it requires it<br>[21:29] to be scheduled beforehand, not that it<br>[21:32] has to finish beforehand.<br>[21:35] So it shows the scheduling order, but it<br>[21:38] allowed for that pull request review<br>[21:40] comments to start while pull request<br>[21:43] reviews was still going. But for smaller<br>[21:46] instances with a very for a very small<br>[21:50] repo, um you saw the successes, but it<br>[21:53] didn't but it didn't um require the<br>[21:56] ordering to keep to be correct. That's<br>[21:58] why we had the<br>[21:59] >> I think that's wrong. the the the docs<br>[22:02] I've been looking at for celery chains<br>[22:04] say that that that it's chains and<br>[22:06] celery allow you to link tasks together.<br>[22:08] The linked task is called when the task<br>[22:11] returned successfully.<br>[22:12] >> You took away the chain.<br>[22:14] >> No, I took the chain and I wrapped I<br>[22:16] instead of having the chain inside the<br>[22:18] group the chain was surrounding the<br>[22:21] group.<br>[22:23] >> I guess I can say in practicality on our<br>[22:26] instance that's not what happened.<br>[22:29] >> Yeah. I yeah I I know that but I also<br>[22:32] our instance is the one anomaly in<br>[22:35] >> I would be curious to see on your is<br>[22:37] your instance still running<br>[22:38] >> is your is your dashboard public?<br>[22:42] >> Um no we don't put anything public.<br>[22:44] >> Um you don't put any access to our<br>[22:46] repository but you do have access to it.<br>[22:48] Um, I'd be curious, Adrian, to look at<br>[22:50] the finish times or the like to see if<br>[22:54] the start time for pull request review<br>[22:57] comments on your instance is<br>[23:02] a actually after the finish time for the<br>[23:05] related pull request reviews because if<br>[23:08] it is then I'm like I'm happy to be<br>[23:10] wrong but then that I'm happy to be<br>[23:12] wrong<br>[23:14] makes it more interesting that it's a<br>[23:16] problem on our instance. I would be<br>[23:18] curious to see what if we're running a<br>[23:19] different celery version or something<br>[23:22] like that, but the screenshot that I saw<br>[23:26] from your instance showed them all to be<br>[23:27] successfully colleed, but I didn't I<br>[23:30] can't see if they the ordering was held<br>[23:34] to the way that it's supposed to.<br>[23:38] >> I can I'll I'm looking into that. Uh<br>[23:41] collect poll request review. Okay,<br>[23:44] so collect poll request reviews.<br>[23:46] received<br>[23:49] 1926 started 1926 succeeded 1926 this<br>[23:53] was all yesterday UTC<br>[23:56] and then the poll request review<br>[23:58] comments it's all 1927<br>[24:02] for this is just for chaos auger repo I<br>[24:04] can screen share if that helps but<br>[24:06] >> yeah I just would look at each one<br>[24:08] because it's like it's a harder thing<br>[24:10] because if it's super quick I don't know<br>[24:12] if it's going to end like yeah let's<br>[24:14] look at each of the example examples<br>[24:20] Um<br>[24:21] because I believe you on that one.<br>[24:23] >> So this is this is collect pull request<br>[24:25] reviews for chaos augur.<br>[24:28] Um everything's basically 1926 UTC.<br>[24:33] Um so it basically started and finished<br>[24:36] within 30 seconds.<br>[24:38] >> Yeah. And so that's why I'm concerned is<br>[24:40] that<br>[24:40] >> like pull request review comments. Well,<br>[24:42] I think this uh<br>[24:45] >> because my thing is that it's I'm saying<br>[24:47] is that for something that is more than<br>[24:48] 30 like the in these longer<br>[24:50] repositories,<br>[24:52] it's requiring that it's like it the<br>[24:54] scheduling order I agree with that's<br>[24:58] happening but it's I think that it's<br>[25:01] allowing it to start or at least we<br>[25:04] could say on our instance it's allowing<br>[25:05] the scheduling order the receive order<br>[25:08] is correct but it is allowing the pull<br>[25:12] pull request review comments to start<br>[25:15] while pull request reviews is still<br>[25:17] going. And so with these shorter like<br>[25:20] with the 30 seconds ones um that it's<br>[25:24] holding up um which is anticipated.<br>[25:28] That's why I was going to say let's try<br>[25:30] to go through a couple different<br>[25:31] examples to see if that's holding for<br>[25:34] all of them. But if you only have really<br>[25:35] small repositories, even if this is a<br>[25:37] problem, I don't know if it's going to<br>[25:39] be shown. Um what's up Sean?<br>[25:42] >> Do do we know that it's running this the<br>[25:45] for the same repository? So is it<br>[25:47] collect do we know that it's collecting<br>[25:48] reviews and review comments for the same<br>[25:51] repository at the same time? for the one<br>[25:54] instance on our so we have we tried to<br>[25:56] run there was a patch that Adrian tried<br>[25:59] yesterday<br>[26:00] um and we only saw one pull request<br>[26:04] review comments get scheduled and that<br>[26:07] one got scheduled and was run and<br>[26:10] completed before its related pull<br>[26:13] request reviews was finished.<br>[26:23] >> All right. So, we have we have one that<br>[26:25] >> any of these repositories sufficiently<br>[26:27] large? I sort of<br>[26:28] >> I don't I would just say let's just look<br>[26:30] at like look at each one and like look<br>[26:32] at some reposi I I don't it's not like<br>[26:34] I'm not going to be able to like look at<br>[26:35] the names of these random repositories<br>[26:38] and know they're<br>[26:39] >> the USD might be on the larger side. So<br>[26:42] that's<br>[26:50] >> you can show more tasks too at the top.<br>[26:52] You can list a 100.<br>[26:54] >> I was I saw it though. So this is uh Z<br>[26:56] Galaxy B USD.<br>[26:58] >> That's comment. It's pull request. It's<br>[27:00] collect pull request. That's not what we<br>[27:01] want.<br>[27:02] >> Well, it was like 1410 and then this one<br>[27:05] was<br>[27:05] >> that's not reviews.<br>[27:06] >> That was We want pull request reviews.<br>[27:08] >> Reviews reviews. Pull request. Yeah.<br>[27:11] Pull request reviews and then pull<br>[27:12] requests.<br>[27:16] >> Just show more tasks. Yeah.<br>[27:18] >> Yeah. Oh, collect. Hey, there we go.<br>[27:23] So, that's not the right one. Okay.<br>[27:26] Reviews 1926.<br>[27:31] So, that was that ended like 30 to 44,<br>[27:34] 57 to 58. So, these are going pretty<br>[27:37] quick.<br>[27:38] >> Yeah. I mean, honestly<br>[27:41] doesn't matter. We're I I don't know if<br>[27:44] it matters with the patch that we're<br>[27:46] coming that we're about to use for this,<br>[27:49] but I would say that in the larger term,<br>[27:53] I think it's beneficial for us to un<br>[27:55] like to go down the rabbit hole to<br>[27:57] understand why this is happening.<br>[28:01] >> Agreed.<br>[28:02] >> Um that like and again I could be wrong.<br>[28:06] I don't know. Like it's you it's<br>[28:08] pointing to something being a little bit<br>[28:10] more complicated that it's not happening<br>[28:12] on Sean's instance and it's happening on<br>[28:14] ours. Um I would love our<br>[28:16] overenthusiastic contributors. Um if<br>[28:20] they want to be helpful right now, it<br>[28:22] would be great for them to and I might<br>[28:23] try to see if people will like if we can<br>[28:26] write this out. This would be a lot more<br>[28:28] useful for them to contribute would be<br>[28:30] to for them to check this<br>[28:32] >> to see if other people's Yeah. What I<br>[28:35] think I saw in the data though is that<br>[28:37] it did very rapidly move through pull<br>[28:40] request reviews and in a very brief time<br>[28:43] period after that do comments.<br>[28:46] >> Yes.<br>[28:46] >> And and it only matters from the<br>[28:48] sequence matters only because that tells<br>[28:49] me whether or not something that we<br>[28:51] expect to be working in celery is. It<br>[28:54] seems like celery is working the way we<br>[28:56] expect it to. But there is still this<br>[28:59] problem with your secondary collection.<br>[29:01] But I would say that the problem that<br>[29:03] we're seeing like with this solution<br>[29:05] would not show up in these like these<br>[29:08] are these tasks are finishing too fast<br>[29:11] for the error that we saw to pimp up<br>[29:13] because they're being received in the<br>[29:15] correct order. They are being scheduled<br>[29:17] in the correct they're like it's the<br>[29:19] chaining is<br>[29:21] >> like pull request reviews is always<br>[29:23] coming before pull request comments. The<br>[29:27] problem is is that pull request reviews<br>[29:29] was still actively running when pull<br>[29:32] request reviews comments was started and<br>[29:34] because comments doesn't have any<br>[29:36] comment like that it's it's able to<br>[29:38] finish so fast because the I would<br>[29:40] assume this is this is getting onto<br>[29:42] assumption land but there's no there's<br>[29:45] no pull request reviews for it to gather<br>[29:47] comments for because it hasn't collected<br>[29:49] the reviews. So pull request reviews<br>[29:51] comments is going to finish really<br>[29:52] quickly and then that's how you can see<br>[29:54] that inversion of like the the<br>[29:57] completion is not<br>[29:59] >> yeah going<br>[30:00] >> I need to ask Andrew about this. I can't<br>[30:02] remember if we did this for the poll<br>[30:04] request review task but in the case of<br>[30:06] of many of the tasks certainly in core<br>[30:09] and facade now we we have it so that<br>[30:12] it's only going to go back and collect<br>[30:14] things that it hasn't already collected.<br>[30:16] It's also possible that it's collected<br>[30:19] basically all the pull request reviews<br>[30:21] previously and in this particular case<br>[30:23] and that's why it's jumping through that<br>[30:25] fast and then jumping through comments<br>[30:27] fast because there's nothing new.<br>[30:28] >> That's that's what I suspect from my<br>[30:30] instance. Yeah. Like<br>[30:31] >> from your instance. Yes. From ours like<br>[30:33] even we were looking at this like hours<br>[30:35] later, pull request reviews was still<br>[30:38] going. Um I don't know if I wish I would<br>[30:40] have taken more screenshots. Um, I don't<br>[30:43] know if I ended up actually sending any<br>[30:45] screenshots to you. Yeah, I took one.<br>[30:47] Um,<br>[30:48] >> how long how long are we letting it run?<br>[30:50] And I'm only asking that because if<br>[30:53] these are larger repositories,<br>[30:55] it it just might be waiting for the<br>[30:57] finish signal. And I have seen this<br>[31:00] before where something I can see from a<br>[31:03] data perspective is finished, but for<br>[31:05] some reason it takes<br>[31:07] >> Flower like two hours to to to recognize<br>[31:10] it's finished.<br>[31:12] So, it's actually even worse than I<br>[31:13] thought. I'll I'll share my screen.<br>[31:16] >> Excellent.<br>[31:16] >> Uh that<br>[31:19] for you can see pull request reviews,<br>[31:22] comments, pull requests, reviews.<br>[31:25] You had pull request, reviews, comments,<br>[31:27] succeed. And this isn't even started<br>[31:29] yet. It's only received.<br>[31:31] >> So, that's possible if you've collected<br>[31:34] the reviews before. Like if<br>[31:37] >> this is these are nulls.<br>[31:40] >> There are no reviews. is there are no<br>[31:41] pull requests. I'm saying that like<br>[31:43] >> it sounds like it might be possible that<br>[31:44] like if because this has been we've been<br>[31:46] running we've been trying to hit<br>[31:48] secondary and try and figure this out<br>[31:49] for a while and I I I imagine like the<br>[31:54] the database would the would the<br>[31:55] database clear out review like so say<br>[31:59] pull request reviews runs it collects<br>[32:02] all the reviews stores them in the<br>[32:03] database but secondary doesn't fully<br>[32:07] complete and get stamped as with a new<br>[32:08] date if the instance gets restarted is<br>[32:12] augur going to clear out those<br>[32:16] entries in the review finishes, you're<br>[32:19] good. Like if if you bring it down while<br>[32:22] the task is still actively going, it<br>[32:24] will clear it out. But if you're if you<br>[32:27] if that singular task does finish, it<br>[32:30] will hold. Um but<br>[32:32] >> sometimes it's also a byproduct of when<br>[32:34] how frequently your instance of the<br>[32:36] Postgress database is doing checkpoints<br>[32:39] as well. But you're right.<br>[32:41] >> I should be fairly<br>[32:42] >> Callie's right. But sometimes if I have<br>[32:44] a checkpoint run, I will get the partial<br>[32:46] collection.<br>[32:49] >> But Callie's point, right? So it sounds<br>[32:52] like this is this screenshot is<br>[32:54] potentially expected then like this is<br>[32:57] okay behavior because if if because<br>[32:59] we've been seeing up until now collect<br>[33:01] pull request reviews run successfully<br>[33:03] and then we just never were seeing<br>[33:04] comments getting scheduled<br>[33:06] >> and now with this patch comments got<br>[33:07] scheduled and it ran successfully based<br>[33:10] on the the potentially based on the<br>[33:12] reviews that were previously collected.<br>[33:14] possibly theory. I guess I don't agree<br>[33:17] with that theory personally, but I would<br>[33:19] talk to like this would be something<br>[33:20] where it's like I would opt to Andrew<br>[33:23] because how would you even how would<br>[33:24] Augur know that it has the pull request<br>[33:27] reviews if the last collected on date is<br>[33:30] null and it hasn't even started? There's<br>[33:33] nothing there's nothing there for it to<br>[33:34] check.<br>[33:35] >> Like the database of the<br>[33:37] >> what? the pull request reviews are in<br>[33:40] the augur data whatever relevant auger<br>[33:42] data table it could just look through<br>[33:44] all like grab all the reviews for that<br>[33:47] >> if if secondary data so we'd have this<br>[33:50] we'd have to look at the way that the<br>[33:51] queries are being run but as a principle<br>[33:53] the secondary data collection if it's<br>[33:55] date of success is null augur is going<br>[33:58] to start assuming it hasn't collected<br>[34:00] anything if it has and that that that<br>[34:04] log entry in the the collection status<br>[34:06] table is wrong um augur will just pass<br>[34:09] over the ones that it's already<br>[34:10] collected very quickly. So that<br>[34:13] >> that's why I'm saying that there's no<br>[34:15] way that Augur knows, hey, this data is<br>[34:17] null, but there's data there until it<br>[34:19] starts the pull request review task.<br>[34:22] >> That's right. That that has to be the<br>[34:24] case. You're you're right that that it<br>[34:27] >> the pull request review task is already<br>[34:28] finished in the last the previous run,<br>[34:31] >> but it's not<br>[34:32] >> Augur doesn't know that. Augur in<br>[34:34] Augur's mind this has never happened<br>[34:36] because in Augur the date is for pull<br>[34:39] request the um last collected on date<br>[34:42] for secondary is null. So in Augur's<br>[34:44] mind this the these tasks have never run<br>[34:48] in the lifetime of the of the instance<br>[34:51] for these repositories.<br>[34:53] >> That's right.<br>[34:55] Once that date has a value, then Augur's<br>[34:58] like, "Cool, I have data up until this<br>[35:01] date, then I start from there." But but<br>[35:04] whenever once this task is started, then<br>[35:07] Augur is like, "Cool, I already have all<br>[35:09] this date. I'm not going to recollect<br>[35:10] recollect and then it goes." But it<br>[35:12] can't it's not going to know that until<br>[35:14] that task starts.<br>[35:17] Does that make sense?<br>[35:20] I think maybe I think we can I think we<br>[35:21] can also discuss like maybe having<br>[35:23] Andrew around I think would probably<br>[35:24] help because I'm<br>[35:25] >> Yeah, for sure.<br>[35:25] >> I'm not fully familiar with like like<br>[35:29] celery like scheduling versus<br>[35:31] >> I think I think what you're seeing there<br>[35:34] is a discontinuity Adrian between what<br>[35:36] is in the collection status table and<br>[35:38] what's running in celery. I've run into<br>[35:40] this myself on longunning repos before<br>[35:42] where the secondary data last collected<br>[35:45] never gets updated for example but the<br>[35:48] tasks all seem to have succeeded on on<br>[35:51] celery and flower and I so sometimes I<br>[35:55] have observed that if I wait many days<br>[35:58] it will eventually get marked completed<br>[35:59] other times I've observed that it<br>[36:02] appears when something runs for longer<br>[36:04] than some amount of time usually at<br>[36:06] least a week if it's if it finishes is I<br>[36:09] actually don't ever get to see that for<br>[36:12] some reason. So I have I've seen these<br>[36:14] I've seen anomalies like this before<br>[36:17] >> if not this particular one and I think I<br>[36:20] think they do arise from the the non<br>[36:24] deterministic nature of celery.<br>[36:28] So I think we're looking at the right<br>[36:29] place.<br>[36:30] >> We were like yesterday we before we<br>[36:32] realized that there was a task not<br>[36:35] scheduling. We were hoping it was a<br>[36:37] similar issue that we were seeing and I<br>[36:38] forget whether it was core or facade<br>[36:40] where all the tasks were running but<br>[36:42] because of I think it was like a because<br>[36:44] of a scheduling issue the success task<br>[36:46] was never going. So we were going to<br>[36:48] manually add the success like tag and<br>[36:51] put it in the date. But because we fi we<br>[36:53] we we figured out that no it's actually<br>[36:56] it's not success because this task is<br>[36:59] never running. So one thing that I'm<br>[37:02] happy about is that for like I think and<br>[37:06] the workaround that Andrew has given<br>[37:10] so like it's not I don't think this is a<br>[37:12] good long-term solution. I don't I think<br>[37:14] we should try to figure out what's going<br>[37:15] on. But I think that it does hold our<br>[37:18] data the data integ in integrity is<br>[37:21] intact and I'm hoping that we can get<br>[37:22] some of these repositories marked as for<br>[37:25] an initial collection and we can kind of<br>[37:27] like start to figure out the nuances<br>[37:29] about this a little bit more to figure<br>[37:31] out where this gap is. Um, but even as<br>[37:35] we go through this more, the workaround<br>[37:38] that that Andrew put forward feels more<br>[37:41] like it's just it's it's a solid it's<br>[37:43] it's a solid workaround<br>[37:47] which I don't know I don't know Sean if<br>[37:48] you are aware of what that is. I'm kind<br>[37:51] of just like it's pretty much<br>[37:52] >> I I am still catching up after being out<br>[37:55] for 10 days so forgive me. I I don't<br>[37:58] know. I was going to say it pretty<br>[38:00] Andrew suggested to just put the pull<br>[38:02] request review comments function call it<br>[38:06] at the end of pull request reviews<br>[38:09] >> that that would ensure that it gets<br>[38:11] called<br>[38:12] right<br>[38:13] >> and it would it would ensure ordering<br>[38:15] and it would ensure it gets called. Is<br>[38:16] that the longterm and that's why I'm<br>[38:18] like is that the long-term solution we<br>[38:20] want here? No, that's not really what<br>[38:23] we're trying to do. But it does solve<br>[38:26] it. And maybe we can start to figure out<br>[38:29] and it might be that we're just at a<br>[38:30] really weird asynchronous point of our<br>[38:32] like larger repository that is caused by<br>[38:35] a nature of all these null dates that<br>[38:38] really shouldn't that are like<br>[38:40] arbitrarily null and they're really<br>[38:42] large and rabbit's freaking out. Um, so<br>[38:46] >> yeah,<br>[38:46] >> it's gonna be interesting to bring that<br>[38:48] to Andrew tonight, especially once we<br>[38:50] test it and see how that goes. So, I<br>[38:54] think I think we've like we beat the<br>[38:56] horse very dead. Um,<br>[38:59] >> I'm we want to Have you gotten a chance<br>[39:01] to start it, Adrian, or we you've been<br>[39:03] kind of<br>[39:04] >> Not yet. I'll do that after this call.<br>[39:06] Um, I did also have a quick question for<br>[39:07] Sean as far as like the release process.<br>[39:09] I know. I mean, maybe this isn't<br>[39:10] necessarily like pre- chaoscon thing,<br>[39:12] but like<br>[39:13] >> I do eventually want to kind of learn<br>[39:15] like what what your process is for<br>[39:17] actually doing a release because it it<br>[39:18] does<br>[39:19] >> I feel like that would be helpful to<br>[39:21] just have some redundancy in how many of<br>[39:23] the core maintainers actually kind of<br>[39:25] know the release process. I I think you<br>[39:27] mentioned on Discord or something that<br>[39:28] you had it doc I don't know if that was<br>[39:31] No, I think that was that was something<br>[39:32] else. But um<br>[39:33] >> it was the install process that uh<br>[39:35] >> yeah that was the install process but<br>[39:36] like having documentation for like what<br>[39:38] what are the steps that a maintainer<br>[39:39] should go through to to do a release I<br>[39:42] think would be helpful to just have so<br>[39:43] that in case you end up like<br>[39:45] unexpectedly busy like I could always do<br>[39:48] a release.<br>[39:48] >> It's an artisan bespoke process right<br>[39:51] now very popular in Portland but not<br>[39:53] necessarily uh something you should do<br>[39:54] for open source software. Um so yeah we<br>[39:58] should write that down. Um, I think<br>[40:00] you're seeing a lot of the critical<br>[40:02] signals which are obviously the CI has<br>[40:05] to all work because I trust that now. I<br>[40:07] didn't used to trust that that was<br>[40:09] finding defects and really the bare<br>[40:12] metal smoke test is the next thing. So<br>[40:15] like that's almost constant where I'm<br>[40:17] constantly running a bare metal smoke<br>[40:18] test. Um, and I just update it whenever<br>[40:21] we have a candidate for release. Uh, I<br>[40:24] am almost always run trying to run off<br>[40:26] of main which is kind of our dev branch.<br>[40:29] uh so that I am not waiting until the<br>[40:31] end to see what's working. So I have a<br>[40:33] test instance working on that. But yes,<br>[40:35] we should write these things down. I<br>[40:36] agree. Um just to give you an idea<br>[40:39] though, it's I don't want you to think<br>[40:40] it's like some mysterious complicated<br>[40:41] process. It's I think you've seen most<br>[40:44] of the parts happen. You just haven't<br>[40:46] seen the artisan bespoke checklist. Um<br>[40:50] that uh just is in my mind, but it needs<br>[40:53] to be elsewhere. So<br>[40:56] >> yeah, if you if you get time at some<br>[40:58] point, I mean, it might have to be after<br>[40:59] Chaos Con at this point, but like<br>[41:01] >> feel free to just if you if you happen<br>[41:03] to write any of that down, like even<br>[41:05] just throw it in an issue and I can I<br>[41:06] can kind of take it from there. But<br>[41:08] >> yeah, I think I think what I'll do is<br>[41:10] while we're working on it tonight, I'll<br>[41:12] just make a note of all of the things<br>[41:13] I'm doing and that will be a a pretty<br>[41:16] good start at that.<br>[41:19] >> Yeah. If y'all I don't know why I<br>[41:22] potentially would be if y'all want any<br>[41:25] of my like point of view on this. I'm<br>[41:28] can't like I'm free from 6:30 to 7. Um<br>[41:31] but I don't know if I'm providing any<br>[41:33] new perspective that at this point y'all<br>[41:36] the two of y'all don't have. Um<br>[41:39] I<br>[41:39] >> I'll let Adrian make that call. I I I<br>[41:43] don't know. I I<br>[41:45] >> I think Cali I think the last invite I<br>[41:47] sent you for for last week's meeting um<br>[41:49] I think I made it like a recurring<br>[41:51] invite so you're you're free to drop<br>[41:52] into the maintainers calls. Um I don't I<br>[41:54] think as far<br>[41:56] >> saying do if you need it is a if you if<br>[42:00] my perspective is helpful I will come<br>[42:03] bring prioritize the thing that you<br>[42:04] would like me to have put in a voice<br>[42:06] within the third first 30 minutes. If<br>[42:08] you were like, eh, either way,<br>[42:11] >> we would never tell you that your<br>[42:12] perspect we would never tell you that<br>[42:13] your perspective is not helpful.<br>[42:16] I think I think it's a question of if<br>[42:18] it's, you know,<br>[42:21] >> helpful. It might speed us along on this<br>[42:24] path.<br>[42:25] >> Like I said, we'll see. Just let me<br>[42:27] know. I'm not<br>[42:29] >> Yeah. The other thing you should<br>[42:31] >> Andrew need anything for me? Need it<br>[42:34] before seven.<br>[42:35] >> Yeah. Okay. Yeah. Andrew and John are<br>[42:37] often late as well, so showing up at<br>[42:39] 5:30 or 6:30 your time might not even<br>[42:42] matter. So,<br>[42:44] >> um, but yeah, we're at time and I have<br>[42:47] another meeting. So,<br>[42:48] >> yeah, me, too. All right, sweet. I will<br>[42:50] talk to you'all later.<br>[42:51] >> Thanks, everyone. Have a great day. TS. <!-- deep-read:sections end --> ๐Ÿ“„ **Full text:** ![[Full Document Contents/Articles/Augur8 Knot WG Meeting, Jan 20, 2026.md|Augur/8 Knot WG Meeting, Jan 20, 2026 by YouTube]] ## Highlights - bugs with that and we were seeing that the the pull request reviews like the first part of that chain was running and getting scheduled and completing but we were not seeing anything even scheduled for the second one. Um and so it's like what what's going on here? Why is this not scheduling? Because if the second piece of that change is not scheduling, that whole group is probably not completing or that whole that whole line is probably not completing and then the whole group is not going and then it's not going to get marked as success. So, it's just kind of like I I do need I do ([View Highlight](https://read.readwise.io/read/01kp9kj3d64qrff2j1kpx6wh4j)) - Tags: ๐Ÿ‘ป ai highlighted - >> What's the task before what what's the last task that you can see in the chain that's scheduled Adrian? >> I mean so all of the >> right before the pull requests like the pull requ the one that goes right before the comments one is we're seeing that succeeding we're just not seeing >> so pull request reviews is succeeding. >> Yes. >> Yes. But then for some reason the the task that's changed immediately after it is somehow not running. That's sort of what leads me to think that this is pro I feel like from my just super quick cursory search of open celery issues ([View Highlight](https://read.readwise.io/read/01kp9kj3gycehaedvs8nbtk3pf)) - Tags: ๐Ÿ‘ป ai highlighted - has to finish beforehand. So it shows the scheduling order, but it allowed for that pull request review comments to start while pull request reviews was still going. But for smaller instances with a very for a very small repo, um you saw the successes, but it didn't but it didn't um require the ordering to keep to be correct. That's why we had the >> I think that's wrong. the the the docs ([View Highlight](https://read.readwise.io/read/01kp9kj3m02d844zfgb32ay7q9)) - Tags: ๐Ÿ‘ป ai highlighted - Um so it basically started and finished within 30 seconds. >> Yeah. And so that's why I'm concerned is that >> like pull request review comments. Well, I think this uh >> because my thing is that it's I'm saying is that for something that is more than 30 like the in these longer repositories, it's requiring that it's like it the scheduling order I agree with that's happening but it's I think that it's ([View Highlight](https://read.readwise.io/read/01kp9kj3r36dvqfzred2hhtnex)) - Tags: ๐Ÿ‘ป ai highlighted - But I would say that the problem that we're seeing like with this solution would not show up in these like these are these tasks are finishing too fast for the error that we saw to pimp up because they're being received in the correct order. They are being scheduled in the correct they're like it's the chaining is >> like pull request reviews is always coming before pull request comments. The problem is is that pull request reviews was still actively running when pull ([View Highlight](https://read.readwise.io/read/01kp9kj3tep5e2m7r6xd5hf6dj)) - Tags: ๐Ÿ‘ป ai highlighted - instance. Yeah. Like >> from your instance. Yes. From ours like even we were looking at this like hours later, pull request reviews was still going. Um I don't know if I wish I would have taken more screenshots. Um, I don't know if I ended up actually sending any screenshots to you. Yeah, I took one. Um, >> how long how long are we letting it run? And I'm only asking that because if these are larger repositories, it it just might be waiting for the finish signal. And I have seen this ([View Highlight](https://read.readwise.io/read/01kp9kj427bw3hk66mgtefb39b)) - Tags: ๐Ÿ‘ป ai highlighted - before where something I can see from a data perspective is finished, but for some reason it takes >> Flower like two hours to to to recognize it's finished. So, it's actually even worse than I thought. I'll I'll share my screen. >> Excellent. >> Uh that for you can see pull request reviews, comments, pull requests, reviews. You had pull request, reviews, comments, succeed. And this isn't even started yet. It's only received. ([View Highlight](https://read.readwise.io/read/01kp9kj45jw20958zfh6tmh45p)) - Tags: ๐Ÿ‘ป ai highlighted